Hi. I think I've found a bug, and a fix, but don't...
# dev
m
Hi. I think I've found a bug, and a fix, but don't know how I can create a PR. Should I create a bug instead? The bug is that QuestionnaireChoiceSetInput() in packages/react/src/QuestionnaireForm/QuestionnaireFormItem/QuestionnaireFormItem.tsx do not check if it's 'choice' or 'openChoice' and the 'createable' prop on is not set, so "creatable" is always "true" even though "openChoice" is not the type.
The fix is adding this line
Copy code
creatable={item.type === QuestionnaireItemType.openChoice}
to the in the QuestionnaireChoiceSetInput()
r
Hi Mats - thanks for looking into this! Instructions on how to submit PR here: https://www.medplum.com/docs/contributing/local-dev-setup
m
Hi. Thanks. I've created a pull request now: https://github.com/medplum/medplum/pull/4089
318 Views